Skip to content

chore(fullsend): remove customized scaffold, bump to v0.43.0, trim roles - #968

Merged
openshift-merge-bot[bot] merged 3 commits into
openshift:masterfrom
samanthajayasinghe:fullsend-bump-v0.43.0
Sep 17, 2026
Merged

openshift-merge-bot[bot] merged 3 commits into
openshift:masterfrom
samanthajayasinghe:fullsend-bump-v0.43.0

Conversation

@samanthajayasinghe

@samanthajayasinghe samanthajayasinghe commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Housekeeping on the fullsend per-repo integration: drops unused scaffold, upgrades to the latest fullsend release, and trims roles to what this repo's Jira integration actually uses. Version pins mirror openshift/ocm-agent-operator (v0.43.0). Modeled on openshift-online/rosa-cora-agent#151.

Commits

1. Remove empty .fullsend/customized/ scaffold folder

The customized/ directory held only .gitkeep placeholders from the original fullsend-0.32.0 per-repo scaffold and was never used. The active Jira integration relies on .fullsend/config.yaml plus the harness/ and policies/ overrides, none of which reference customized/.

2. Bump fullsend to v0.43.0

Update all fullsend version pins to v0.43.0, using the exact hashes from openshift/ocm-agent-operator:

File Pin Change
.github/workflows/fullsend.yaml reusable-dispatch.yml @2db46c4… (v0.38.0) → @d5f36921… (v0.43.0)
.github/workflows/fullsend-poll-jira.yml gh release download v0.38.0 → v0.43.0
.github/workflows/fullsend-poll-jira.yml harness reusable-dispatch.yml @2db46c4… (v0.38.0) → @d5f36921… (v0.43.0)
.fullsend/harness/code.yaml agents base @48511880… → @7ab05564… (refreshed sha256)
.fullsend/harness/triage.yaml agents base @48511880… → @7ab05564… (refreshed sha256)

Verified the v0.43.0 reusable-dispatch.yml signature (required inputs mint_url, gcp_region; required secret FULLSEND_GCP_PROJECT_ID) is backward-compatible with the existing shim. Repo-specific values (repository gate, ROSAENG JQL, master target branch) are left unchanged.

3. Remove review, retro, and prioritize roles from fullsend config

These roles are not used by this repo's Jira integration (no review/retro/prioritize agents are registered in the agents: section). Roles are now triage, coder, fix, matching the registered triage and code agents. (osdctl carried a prioritize role in addition to the review/retro removed in the reference PR; it is dropped here for the same reason.)

Testing

  • All modified YAML validated (yq).
  • No lingering references to customized/ or old version pins.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Changes
    • Updated the Fullsend automation tooling to version 0.43.0 for workflow execution.
    • Refreshed automation references to use the latest approved upstream version.
    • Available configured roles are now limited to triage, coder, and fix; review, retro, and prioritize are no longer available.
  • Chores
    • Updated scheduled Jira polling and dispatch automation to align with the newer tooling version.

samanthajayasinghe and others added 3 commits September 17, 2026 15:30
The customized/ directory held only .gitkeep placeholders from the
original fullsend-0.32.0 per-repo scaffold and is unused. The active
Jira integration relies on .fullsend/config.yaml plus the harness/
and policies/ overrides, none of which reference customized/.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Update all fullsend version pins to v0.43.0, matching the hashes used in
openshift/ocm-agent-operator:

- fullsend.yaml / fullsend-poll-jira.yml: reusable-dispatch.yml pinned to
  d5f36921ac754705619f38c637ef692873809fbc (# v0.43.0).
- fullsend-poll-jira.yml: fullsend binary release download v0.38.0 -> v0.43.0.
- harness/code.yaml, harness/triage.yaml: agents base pinned to
  7ab05564b3c9c0ab20197e0c8572b5905ffd75ca with refreshed sha256 digests.

Repo-specific values (repository gate, ROSAENG JQL, master target branch) are
left unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The review, retro, and prioritize roles are not used by this repo's Jira
integration (no review/retro/prioritize agents are registered in the
agents: section). Keep only the triage, coder, and fix roles.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8d5ca6e9-574b-400c-8941-1ffab5d671dd

📥 Commits

Reviewing files that changed from the base of the PR and between 85f8659 and 524038f.

📒 Files selected for processing (15)
  • .fullsend/config.yaml
  • .fullsend/customized/agents/.gitkeep
  • .fullsend/customized/env/.gitkeep
  • .fullsend/customized/harness/.gitkeep
  • .fullsend/customized/plugins/.gitkeep
  • .fullsend/customized/policies/.gitkeep
  • .fullsend/customized/profiles/.gitkeep
  • .fullsend/customized/providers/.gitkeep
  • .fullsend/customized/schemas/.gitkeep
  • .fullsend/customized/scripts/.gitkeep
  • .fullsend/customized/skills/.gitkeep
  • .fullsend/harness/code.yaml
  • .fullsend/harness/triage.yaml
  • .github/workflows/fullsend-poll-jira.yml
  • .github/workflows/fullsend.yaml
💤 Files with no reviewable changes (1)
  • .fullsend/config.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


Walkthrough

Changes

Fullsend now uses roles triage, coder, and fix. Its harness pins and GitHub Actions workflow references were updated to newer upstream revisions and version v0.43.0.

Fullsend updates

Layer / File(s) Summary
Harness configuration updates
.fullsend/config.yaml, .fullsend/harness/*.yaml
The roles list removes review, retro, and prioritize. The code and triage harnesses use updated upstream commits and checksums.
Workflow version updates
.github/workflows/fullsend*.yml
The workflows install or reference Fullsend v0.43.0 instead of v0.38.0.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 52403

No concrete merge-blocking regression from these version and role updates was established.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main changes: removing the customized scaffold, updating Fullsend to v0.43.0, and trimming unused roles.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The pull request changes only Fullsend YAML/workflow configuration and deletes empty .gitkeep scaffold files. The reviewed diff contains no Ginkgo test declarations or test-title construction,…
Test Structure And Quality ✅ Passed PASS: The pull request does not add or modify Ginkgo tests. The authoritative diff changes only YAML/workflow files and deletes empty .gitkeep scaffold files. No changed test paths or added Ginkgo c…
Microshift Test Compatibility ✅ Passed The pull-request range adds no Go files, test files, or Ginkgo declarations. It changes only Fullsend configuration, harness pins, workflows, and empty scaffold markers. Therefore, the MicroShift test…
Single Node Openshift (Sno) Test Compatibility ✅ Passed The check is not applicable. The review-scoped diff changes only Fullsend YAML configuration, workflow pins, and empty .gitkeep scaffold files. It adds or modifies no Go, Ginkgo, or e2e test code, a…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The PR changes only Fullsend configuration, harness pins, GitHub workflow references, and empty scaffold files. It does not add or modify deployment manifests, operator code, controllers, replic…
Ote Binary Stdout Contract ✅ Passed PASS. The authoritative PR diff changes five YAML files and deletes ten .gitkeep scaffold files; it changes no Go source. The added and removed lines only alter Fullsend roles, pinned remote harness…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The authoritative PR diff changes Fullsend YAML configuration, harness pins, workflows, and deletes empty scaffold files. It adds or modifies no Ginkgo e2e tests and introduces no test networking or e…
No-Weak-Crypto ✅ Passed The pull request does not introduce weak cryptography. Changed files contain YAML and workflow pin updates only. The new integrity fields use SHA-256, and the other hashes are Git commit identifiers. …
Container-Privileges ✅ Passed PASS: The PR changes Fullsend configuration, harness references, and GitHub workflows. The authoritative diff adds no container or Kubernetes manifest settings for privileged: true, hostPID, `host…
No-Sensitive-Data-In-Logs ✅ Passed PASS. The pull-request diff adds no logging commands or log destinations. It changes Fullsend pins, removes scaffold files, and trims roles. The local workflow still passes Jira and telemetry secrets …
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from bergmannf and geowa4 September 17, 2026 03:35
@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@samanthajayasinghe: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@RaphaelBut

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2026
@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RaphaelBut, samanthajayasinghe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 77553c6 into openshift:master Sep 17, 2026
38 checks passed
@fullsend-ai-retro

fullsend-ai-retro Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 11:20 AM UTC · Completed 11:29 AM UTC

Commit: 524038f · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.43

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #968 — fullsend housekeeping bump

PR #968 was a clean housekeeping PR by samanthajayasinghe (co-authored with Claude Opus 4.8) that removed unused .fullsend/customized/ scaffold directories, bumped all fullsend version pins from v0.38.0 to v0.43.0, and trimmed unused roles (review, retro, prioritize) from .fullsend/config.yaml. The workflow was efficient: CodeRabbit found no issues, CI tests passed, RaphaelBut approved via /approve /lgtm, and the PR merged the same day. No code, review, or fix agents were dispatched — only this retro.

Finding: stale version comments in harness configs

The PR updated the SHA pins in .fullsend/harness/code.yaml and .fullsend/harness/triage.yaml to point to the v0.43.0 agents commit (7ab05564...), but the inline comments still say "pinned to agents v0.38.0" and describe v0.38.0-specific behavior. This was missed by both CodeRabbit and the human reviewer. A proposal to fix this is included below.

Evidence for existing issues (no new proposals needed)

Proposals filed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants